search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

Support in_app field for stacktrace frames #7

Closed minimal closed 9 years ago

minimal commented 9 years ago

wrap-sentry and stacktrace now take an optional namespaces arg which should be a list of namespace prefixes which you want to be treated as in_app by sentry.

The stacktrace map is changed to support the exception interface.

screenshot 2014-10-16 10 23 58

screenshot 2014-10-16 10 24 14

minimal commented 9 years ago

Is there a chance of this getting looked at? I'd rather not maintain my own fork on clojars. Cheers.

sethtrain commented 9 years ago

Absolutely, I will try to get this done today. Sorry for letting it slip on my radar.

minimal commented 9 years ago

Cool, thanks.

sethtrain commented 9 years ago

I'm not going to be able to get to this tonight but will address it first thing in the morning when I get into the office.

sethtrain commented 9 years ago

This is now on Clojars -> https://clojars.org/raven-clj. I didn't do much testing of your commits here but wanted to go ahead and get it out so you don't have to maintain another fork. If something comes up I might ask for assistance, that okay with you?

minimal commented 9 years ago

That's great thanks! It should be backwards compatible if you don't pass the optional arg. We've been running a variant in production for a couple of months now but ping me if you need to.

Cheers