search

sethtrain / raven-clj

A Clojure interface to Sentry
84 stars 29 forks source link

Update clj-http, exclude Clojure itself #9

Closed semperos closed 8 years ago

semperos commented 8 years ago

Updates to latest stable clj-http. Also removes Clojure as primary dependency, since consumers of the library will specify the version of Clojure they need in their applications.

You can run the test suite for different Clojure versions as follows:

lein with-profile clj-1.5 test
lein with-profile clj-1.6 test
lein with-profile clj-1.7 test
lein with-profile clj-1.8 test

As it happens, this library passes with versions 1.5.1 through 1.8.0-RC3.

martinklepsch commented 8 years ago

👍 yes please!

martinklepsch commented 8 years ago

@semperos I'm not sure I see a drawback in specifying the Clojure dependency — users will override it with their version if they specify one. What do you think?

martinklepsch commented 8 years ago

@semperos I'll close this for now, if you're still interested in getting the profiles merged, please update this PR or open a new one without the clj-http update.