sethvargo / terraform-provider-berglas

A Terraform provider for Berglas
Apache License 2.0
17 stars 6 forks source link

Initial implementation of `berglas grant` #7

Closed glasnt closed 4 years ago

glasnt commented 4 years ago

WIP implementation

Missing read/update functions, tests.

Question: berglas itself doesn't supply a read for membership, so I'm thinking I should implement something like iamMemberImporter. Having a read command is needed for terraform to know if updates are required (I'm guessing)

Any pointers would be useful.

glasnt commented 4 years ago

Does it make sense to reimplement iamMemberImport, or should I call it and rely on importing another provider?

I would say reimplement, but the abstraction that iamMemberImport relies on is confusing me.

sethvargo commented 4 years ago

The import one is just for importing IAM resources. You'd need to do something more along the lines of read, parsing the policy and iterating over all the members.