search

sethwebster / GoogleMaps.LocationServices

A simple library (including Nuget Package) for Google Maps geolocation and reverse geolocation
http://nuget.org/List/Packages/GoogleMaps.LocationServices
44 stars 42 forks source link

I added an api key as a parameter #12

Closed adrotter closed 7 years ago

adrotter commented 7 years ago

Note that I wasn't able to get any coordinates from the addresses provided in the console program, so I am not sure if the program works. But the URL doesn't throw a key related error when used with a proper key.

adrotter commented 7 years ago

also, the apikey is optional, just leave the string blank if no key is provided.

sethwebster commented 7 years ago

Sorry for the delay. @adrotter, can you resolve these conflicts? Thanks!

adrotter commented 7 years ago

I'm sorry @sethwebster, what conflicts? Merge conflict?

sethwebster commented 7 years ago

Yes; there are conflicts.

Seth Webster @sethwebster http://twitter.com/sethwebster | web site http://sethwebster.com/ | photography http://photos.sethwebster.com/ | IMDB http://www.imdb.com/name/nm0917003/?ref_=fn_al_nm_1 | +1.646.350.0739 (c)

On Wed, Apr 26, 2017 at 8:14 PM, adrotter notifications@github.com wrote:

I'm sorry @sethwebster https://github.com/sethwebster, what conflicts? Merge conflict?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sethwebster/GoogleMaps.LocationServices/pull/12#issuecomment-297576178, or mute the thread https://github.com/notifications/unsubscribe-auth/AApisa_5MtxFxPEhAhqjIeCZu92Ms3cjks5rz934gaJpZM4MTA_K .

sethwebster commented 7 years ago

Since the apiKey would most likely be used across any of the requests, why not add it in the constructor or as a settable property, @adrotter ?

adrotter commented 7 years ago

I'm going to close and open a new pull request since you've done a lot of work since this one and I want to start from your current code.

sethwebster commented 7 years ago

Great thx.

On Sat, Apr 29, 2017, 7:14 PM adrotter notifications@github.com wrote:

Closed #12 https://github.com/sethwebster/GoogleMaps.LocationServices/pull/12.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sethwebster/GoogleMaps.LocationServices/pull/12#event-1063280823, or mute the thread https://github.com/notifications/unsubscribe-auth/AApisXYL9wHSiCwMt_v0BgR-3NgjMuJUks5r08RKgaJpZM4MTA_K .