sethyuan / logseq-plugin-another-embed

This plugin provides 2 extra ways to embed blocks/pages.
MIT License
23 stars 1 forks source link

Remove shortcut settings for the sake of Keymap & Helpful change of README #16

Closed stdword closed 11 months ago

stdword commented 11 months ago

Removed shortcut settings for the sake of Keymap

Added setup of original Logseq way to hide certain properties

NOTE 1: I didn't change Chinese version (don't know the language)

NOTE 2: Displaying block properties feature could be cut off from the plugin if this is the only reason of it's existence.

sethyuan commented 11 months ago

Thanks for this addition to the doc. I'll add the respective Chinese part. Actually, Another Embed integrates a few helpful features that are too small to be a plugin of their own.

sethyuan commented 11 months ago

BTW, regarding the shortcut changes, I don't think they are necessary because users can still remap the shortcuts via the keymap dialog. In fact, some users have the habits of configuring the shortcuts of one plugin in its own plugin settings.

stdword commented 11 months ago

some users have the habits of configuring the shortcuts of one plugin in its own plugin settings

But there is a problem: plugin settings doesn't sync with Keymap.

My thoughts here: The Keymap will change users habits for changing shortcuts. Just need some time. And cutting off the settings will speed up the evolution.

But you are the owner 🙏

sethyuan commented 11 months ago

But there is a problem: plugin settings doesn't sync with Keymap.

What do you mean by they don't sync with Keymap? I believe the users can still change a shortcut via Keymap if they want to.

stdword commented 11 months ago
  1. Change shortcut via Keymap (it will work)
  2. Restart the app
  3. The plugin setting will use an old value of shortcut and changing this value won't work.

Once user uses Keymap — this setting becomes broken.

sethyuan commented 11 months ago

You're right, still, I'd prefer to leave the plugin settings theres as this hands over the decision to users.

stdword commented 11 months ago

Ok, I've reverted these lines

sethyuan commented 11 months ago

Thanks!