Feature-Request: Fixed reminding time for scheduled or deadline without time?

[mschiff]

Currently there is no reminder for events without a time set.

It would be nice to have some setting, where you can activate a feature so that the plugin will also remind me of events without time for a day at a time specified in the settings , like:

  reminding of schedules or deadline without time: true/false (default false)
  reminding time: 08:00

What do you think?

[sethyuan]

Good idea, I'll see what I can do.

[sethyuan]

@mschiff This is implemented now.

[mschiff]

Awesome! I checked it out, and it works. Mostly. I think this is a bug:

• reminded me today (2023-09-04) for an event in the future: DEADLINE: <2024-01-31 Wed>

I have some suggestions about the behavior that I would expect:

• I would leave out the time in the notification message for SCHEDULED and DEADLINE without time
• Improved description for hasDefaultReminding: "Enable a default reminding time for SCHEDULED and DEADLINE without time."
• The description for defaultRemindingTime mentions the variable name which is invisible in the GUI, so maybe better would be something like "Default reminding time (in 24-hour format) for SCHEDULED and DEADLINE without time" (I think its intuitive then, that one has to enable that feature.
• I would not expect the remindings to be applied to SCHEDULED and DEADLINE without time because these do not have a time and therefore only the current day is important for them

Additionally:

• had to restart logseq after config change to make it work, maybe would be useful to mention that in the README
• README is now outdated as events without time might not be ignored any more

Thanks again for implementing this feature. Much appreiciated!

[sethyuan]

@mschiff All bugs and suggestions are handled. Please take a look of the new version.

[mschiff]

I just updated to the new version. I really appreciate it, thanks!

I noticed one thing though: Events without time still still have the additional reminders from the remindings setting applied. So this does not seem to work as it should be or as I would expect. What I meant above as my 4th bullet was that reminders without time do not need several reminders a day but just one at the specified time set in the settings (defaultRemindingTime), so for them I think its better if additional reminders from the reminders setting would be ignored for them

Thanks again!

[sethyuan]

Oh I see, I'll handle it.

[sethyuan]

@mschiff Done.

[mschiff]

Works, great! Thanks again!