search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
231 stars 52 forks source link

IconHash prefix fix #112

Closed drtaru closed 9 months ago

drtaru commented 9 months ago

This PR moves the iconHashPrefix portion up in the script from L~900 ish, more readily exposing it to the Admin. It also adds a note reminding the user to make sure the prefix matches their environment.

This should help alleviate the issues that have stemmed from Jamf geolocating icons in different hosting regions.

dan-snelson commented 9 months ago

Thanks, @drtaru.

(Now that we have SYM-Helper, I'm wondering if we can simply delete setupYourMacPolicyArrayIconPrefixUrl.)

drtaru commented 9 months ago

Hey Dan, this would probably be ok, however this would be a šŸ”„BREAKING CHANGEšŸ”„ for anyone who already has the script configured and their PolicyJSON's set and is just looking to upgrade scripts using comparison tools.

For example, while SYM-Helper is a great tool, I probably personally will never use it due to my familiarity with the script. I'm sure there are others who are in the same position.

dan-snelson commented 9 months ago

Fair points.

(What if in SYM 1.13.0 we used a FQDN for all icon inside policyJSON ?)

drtaru commented 9 months ago

Yes that would be the true fix, Change the example policyJSON to have the FQDN, remote the iconprefix stuff entirely, and note the breaking change in the release notes.

dan-snelson commented 9 months ago

@drtaru:

OK if I close this PR? See: https://github.com/dan-snelson/Setup-Your-Mac/blob/1.13.0/Setup-Your-Mac-via-Dialog.bash#L15-L16

dan-snelson commented 9 months ago

@drtaru: Am I OK to close this PR?

drtaru commented 9 months ago

Sorry, GH doesn't always alert me of replies, yes as discussed this can go away now since we are requiring full URLs in the policyJSON