search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
231 stars 52 forks source link

welcomeDialog set to "false" does not turn off the chack for welcomeBannerImag #129

Closed Honestpuck closed 5 months ago

Honestpuck commented 5 months ago

Describe the bug When I set welcomeDialog="false" I still get the test for the welcomeBannerImage

To Reproduce I am running the script from iTerm as sudo ./Setup-Your-Mac-via-Dialog.bash

welcomeDialog is set to false debugMode is set to verbose

Expected behavior I expected that all features surrounding the welcome dialog would be turned off.

Code/log output

2024-01-15 13:31:11 - WELCOME DIALOG: welcomeBannerImage is not available, using a default image
2024-01-15 13:31:11 - WELCOME DIALOG: Auto-caching hosted 'green-abstract-geometric-wallpaper_52683-29623.jpg' …

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context I'm also seeing "Test Connection" under the icon on the left and it sticks. I haven't done much to pin that down yet.

dan-snelson commented 5 months ago

@Honestpuck:

Will you please test with 1.14.0, changing welcomeDialog="${6:-"false"}"

timestamp=$( date '+%Y-%m-%d-%H%M%S' ) ; curl -o ~/Downloads/Setup-Your-Mac-via-Dialog-$timestamp.bash https://raw.githubusercontent.com/setup-your-mac/Setup-Your-Mac/1.14.0/Setup-Your-Mac-via-Dialog.bash ; sudo bash ~/Downloads/Setup-Your-Mac-via-Dialog-$timestamp.bash

I'm seeing the following:

2024-01-20 06:49:45 - PRE-FLIGHT CHECK: Complete
2024-01-20 06:49:46 - WELCOME DIALOG: brandingBanner is available, using it
2024-01-20 06:49:46 - WELCOME DIALOG: Auto-caching hosted 'green-abstract-geometric-wallpaper_52683-29623.jpg' …

Screenshot 2024-01-20 at 6 50 46 AM

Honestpuck commented 5 months ago

OK. Both before and after I make it "false" I'm getting 

sudo bash ./Setup-Your-Mac-via-Dialog-2024-01-21-144243.bash
2024-01-21 14:45:39 -

###
# Setup Your Mac (1.14.0-b1)
# https://snelson.us/sym
###

2024-01-21 14:45:39 - PRE-FLIGHT CHECK: Initiating …
2024-01-21 14:45:39 - PRE-FLIGHT CHECK: This script must be run under 'bash', please do not run it using 'sh', 'zsh', etc.; exiting.

I made the script executable and ran sudo ./Setup-Your-Mac-via-Dialog-2024-01-21-144243.bash and got the same as you.

2024-01-21 14:57:34 - PRE-FLIGHT CHECK: Complete
2024-01-21 14:57:36 - WELCOME DIALOG: brandingBanner is available, using it
2024-01-21 14:57:36 - WELCOME DIALOG: Auto-caching hosted 'green-abstract-geometric-wallpaper_52683-29623.jpg' …
2024-01-21 14:57:37 -

I also got a working dialog with welcomeDialog set to userInputwith the same lines.

Honestpuck commented 5 months ago

I have to say that it is now much faster to display the dialog. I think we can call this closed.

dan-snelson commented 5 months ago

Addressed in SYM 1.14.0.