search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
249 stars 55 forks source link

Incorrect failure message displayed #149

Closed arnoldtaw closed 3 months ago

arnoldtaw commented 5 months ago

Describe the bug Upon detecting a failure, the correct failure message was not displayed. Instead, it displayed the placeholder text. Placeholder message; update in the 'finalise' function

To Reproduce Unable to reproduce consistently. Correct customized failure message was displayed in most cases. Once in a while, we will get this message.

Expected behavior Upon detecting a failure, display the correct failure message.

Code/log output N/A

Screenshots Screenshot 2024-05-07 at 8 26 23 AM

Environment:

jcmbowman commented 4 months ago

I'm consistently running into this bug. Glad it's already been identified. Happy to assist with troubleshooting.

jcmbowman commented 4 months ago

Fixed on my end by changing sleep time to 0.7 here: https://github.com/setup-your-mac/Setup-Your-Mac/blob/084c8293115df89fd9db0343cacb45ec99b01631/Setup-Your-Mac-via-Dialog.bash#L1719

dan-snelson commented 4 months ago

@arnoldtaw: While I'm aware of other reports of this unexpected behavior, I'm not able to replicate it.

That said, please advise if 1.15.0-b7 resolves the issue.

Thanks.

dan-snelson commented 3 months ago

Addressed in SYM 1.15.0.