Closed rougegoat closed 1 year ago
Thanks again, @rougegoat.
I'm now observing a CONFLICT (content): Merge conflict in Setup-Your-Mac-via-Dialog.bash
when attempting to merge; I think we were both making updates.
Will you please resubmit?
@rougegoat: Actually, will you please give me a few minutes to add some local fixes?
@rougegoat: I just pushed 1.10.0-rc23
; thanks so much.
I have rebuilt using rc-23, and that looks to have fixed the conflict.
As requested over in my last PR, here's a new one that adds the option to disable the Username value. I think I held off on that initially because of the possibility of a trailing comma if certain combinations were disabled. I've reworked it a bit to ensure that there won't be trailing comma in any combination of prompts. You should now be able to enable or disable all of the ones on the Welcome page without breaking the next steps.
I also went ahead and made it so that if the Configuration prompt is disabled it also removes mention of configurations from the Welcome text.
I think this will be my last PR before the next official release assuming everything works as expected.