search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
246 stars 54 forks source link

Option to disable Banner Text #42

Closed rougegoat closed 1 year ago

rougegoat commented 1 year ago

Added a flag to hide the Banner Text. Handy if the Banner Image has text in it already.

drtaru commented 1 year ago

I'm concerned with line 1502. This line normally changes the title if there is a failure and works if there is a banner image or not, unsure why you would only show this if branding banner text is set to true.

rougegoat commented 1 year ago

The main thing this toggle addresses is situations where the branded banner already has text in it. In those situations, printing the Banner Text on top of the existing text in the image can make it extremely difficult to read.

As for 1502 in particular, that title change only tells them that something has gone wrong. That information is also provided by the main body and the next screen. Normally it's fine to show, but if it's going to be hard to read anyway you may as well hide it.