search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
246 stars 54 forks source link

Streamline policyJSON Section #43

Closed rougegoat closed 1 year ago

rougegoat commented 1 year ago

Split each potential step out into a separate variable that can be added Centralized these variables in one section Simplified how to change what gets deployed in Required, Recommended, and Complete Reduced duplicate code, which reduces future modifications people need to make

This also helps streamline adding future steps for programs not currently included.

rougegoat commented 1 year ago

Sorry for all the PRs! Sometimes I gotta get an idea out before I forget it.

dan-snelson commented 1 year ago

Thanks, @rougegoat.

(I'll take a look once 1.10.0 is released.)

dan-snelson commented 1 year ago

@rougegoat: Please give me some time to counsel with others on how best to proceed with this PR. Thanks.

rougegoat commented 1 year ago

Understandable. I should note the main goal here was less rewriting it for à la carte style app installs and more reducing duplicate code. That way, going forward if you have to update the Rosetta or Recon (for example) json snippets, you only have to adjust it in one place instead of four. It's just that when this is done, it kind of opens the door to that functionality should that route be needed down the line.

theadamcraig commented 1 year ago

I like the core concept of this idea a lot.