search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
238 stars 52 forks source link

Configuration Names and Descriptions as Variables #60

Closed theadamcraig closed 1 year ago

theadamcraig commented 1 year ago

I've added variables for configuration names and descriptions to make one set of variables that need updated to update the configurations throughout the entire script.

This will make the script easier to customize for people who want different names and application sets for their configurations.

drtaru commented 1 year ago

The only issue I see with this is it implies a limitation of three configurations which is not the case, you can have as many as you want / need.

dan-snelson commented 1 year ago

Thanks, @theadamcraig!

Fair point, @drtaru, but I do see this as an improvement to the currently hard-coded Configuration labels we're using internally.

dan-snelson commented 1 year ago

@theadamcraig: I just changed the base branch from main to 1.11.0 and there are now conflicts.

Please resolve. Thanks.

theadamcraig commented 1 year ago

I've updated to resolve the conflicts.

@drtaru I hope that these changes will help users who want to add a 4th, or more, configurations find out where they need to be updated by being able to easily search and find variable names.