setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
238 stars 52 forks source link

Add scope for setups that do not open Self Service on enrolment to SYM cases that handle completionAction #71

Closed master-vodawagner closed 11 months ago

master-vodawagner commented 1 year ago

Before submitting a Setup Your Mac bug report, please review the open swiftDialog issues to help determine the source of the issue.

Describe the bug Currently SYM has a list of cases for completionAction (In my case Restart-Attended), SYM when actioning the case looks to kill the Self Service process and waits for that to complete, however my company and others I;m sure are not launching Self Service during setup and I believe this is causing a hung state where devices are not triggering the restart due to no process running for Self Service and the wait command is causing SYM to become stale

To Reproduce Uncheck Launch Self Service when done under Jamf Pro > Settings >Global > User-initiated enrollment Run through SYM

Expected behavior Device to process a restart no matter if Self Service is running or not

Code/log output The Self service process is not running

Screenshots NA

Environment (please complete the following information):

Additional context Add any other context about the problem here.

dan-snelson commented 1 year ago

Thanks, @master-vodawagner; I think I've replicated this behavior in our Jamf Cloud Beta instance.

I'll take a look.

dan-snelson commented 1 year ago

@master-vodawagner:

In a single test, this is resolved in 1.12.0-b6 by using a different one-liner (which is already detailed in I. Troubleshooting > 6. Various Restart Completion Actions not Working as Expected.)

dan-snelson commented 1 year ago

@master-vodawagner:

SYM 1.12.0-rc1 reverts this code change from 1.12.0-b6 as in my testing following I. Troubleshooting > 6. Various Restart Completion Actions not Working as Expected resolved the issue.

dan-snelson commented 11 months ago

@master-vodawagner:

Please see: I. Troubleshooting > 6. Various Restart Completion Actions not Working as Expected.