setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
238 stars 52 forks source link

Limit the swiftdialog to tested or supported version with SYM. #72

Closed mani2care closed 1 year ago

mani2care commented 1 year ago

I have a doubt regarding the installation of SYM and SwiftDialog. SYM is supported and tested with version 1.11.0, and SwiftDialog version 2.2. However, I noticed that version 2.2.1 is untested by Dan. Are there any limitations in SYM scripts for downloading and installing SwiftDialog? Installing an untested higher version, like 2.2.1, may cause issues in production, so why don't we limit the version installation to a tested version?

BigMacAdmin commented 1 year ago

SYM already only installs SwiftDialog if it is not already there. If this is a concern for you, you can install your desired version of SwiftDialog prior to kicking off SYM

https://github.com/dan-snelson/Setup-Your-Mac/blob/e8611766963ebb8d7b5498c28a2ecc907fe2099a/Setup-Your-Mac-via-Dialog.bash#L377

mani2care commented 1 year ago

I agree for example sym supports and tested the swiftdialog 2.2.1 and tomorrow swiftdialog will publish other latest versions 2.3 then sym will attempting to download latest version only we may not aware is that supported or test it may chances to give us to trouble.

When we have control to limit to defined versions to download and install it will be good to have.

In sym just we need swiftdialog supported version control.

It’s my suggestion.

On Thu, 22 Jun 2023 at 11:09 PM, BigMac Admin @.***> wrote:

SYM already only installs SwiftDialog if it is not already there. If this is a concern for you, you can install your desired version of SwiftDialog prior to kicking off SYM

https://github.com/dan-snelson/Setup-Your-Mac/blob/e8611766963ebb8d7b5498c28a2ecc907fe2099a/Setup-Your-Mac-via-Dialog.bash#L377

— Reply to this email directly, view it on GitHub https://github.com/dan-snelson/Setup-Your-Mac/issues/72#issuecomment-1603067038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUGJU32WUUNTZPDBEPNCX3XMR7OFANCNFSM6AAAAAAZQQ5YRA . You are receiving this because you authored the thread.Message ID: @.***>

-- Thanks & Regards,

Manikandan R Contact: +91-9902103878 E-mail: @.***

BigMacAdmin commented 1 year ago

My point is that your suggestion would require the authors to update SYM, even if no changes are required in order to support v2.3.

perhaps you have need to stay on v.2.1 for some other reason. As written, SYM will respect this.

mani2care commented 1 year ago

Today sym is supported 2.2 versions as per the document

But in sym code is attempting to download 2.2.1 as latest version tomorrow 2.3 is published then we not known who’s many new enrollment user will affect on this

If we have some functionality to say and download only 2.2 the it’s good and we can test the latest version and change the script allow to download the 2.3

I mean to if we have options it’s good to have and if I know we’ll with scripts definitely I will do contribute but let me learn and try.

On Thu, 22 Jun 2023 at 11:20 PM, BigMac Admin @.***> wrote:

My point is that your suggestion would require the authors to update SYM, even if no changes are required in order to support v2.3.

perhaps you have need to stay on v.2.1 for some other reason. As written, SYM will respect this.

— Reply to this email directly, view it on GitHub https://github.com/dan-snelson/Setup-Your-Mac/issues/72#issuecomment-1603081807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUGJU2BRWLX5IDEL7BVIW3XMSAX3ANCNFSM6AAAAAAZQQ5YRA . You are receiving this because you authored the thread.Message ID: @.***>

-- Thanks & Regards,

Manikandan R Contact: +91-9902103878 E-mail: @.***

dan-snelson commented 1 year ago

@mani2care:

As mentioned on the MacAdmins Slack #setup-your-mac Channel, if you'd like to control the version of swiftDialog installed on your fleet, please go with @BigMacAdmin 's suggestion and install the desired version as a .PKG in your Jamf Pro policy.

Closing as "not planned."