setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
249 stars 55 forks source link

When using Prompt-to-Setup-Your-Mac with Setup-Your-Mac, quitting a prompt from the former results in the "catch-all" configuration being run in the main script #83

Closed justintrant closed 1 year ago

justintrant commented 1 year ago

Describe the bug When using Prompt-to-Setup-Your-Mac with the main Setup-Your-Mac script, quitting a prompt from the former results in the "catch-all" configuration being run in the main script. This results in the deployment failing.

To Reproduce

Expected behavior Quitting the swiftDialog prompt should result in the same behavior as the user clicking 'OK', and not result in the primary script running the "Catch-all" configuration once it is run from Self Service.

Environment

Additional context https://macadmins.slack.com/archives/C04FRRN3281/p1692104941846579

dan-snelson commented 1 year ago

@justintrant: While Prompt-to-Setup-Your-Mac.bash has been updated, I'm confident your issue was related to other environmental variables.

Please re-re-re-test with:

justintrant commented 1 year ago

Hi @dan-snelson,

Tested and confirming that the issue is resolved. Thanks so much!

Justin.