search

setup-your-mac / Setup-Your-Mac

Setup Your Mac aims to simplify initial device configuration by leveraging swiftDialog and Jamf Pro Policy Custom Events to allow end-users to self-complete Mac setup post-enrollment.
https://snelson.us/sym
MIT License
238 stars 52 forks source link

When welcomeDialog is set to false do not create command file and do not check for welcomeBannerImage #86

Closed Honestpuck closed 11 months ago

Honestpuck commented 11 months ago

As one of the people who turns off the Welcome dialog by setting welcomeDialog="${6:-"false"}" I noticed that the command file /var/tmp/dialogCommandFileWelcome.XXX is still created, a minor issue.

More important is that welcomeBannerImage is checked and the default downloaded and cached. From the debug output

2023-08-22 11:24:52 - WELCOME DIALOG: welcomeBannerImage is not available, using a default image
2023-08-22 11:24:52 - WELCOME DIALOG: Auto-caching hosted 'yellow-watercolor-paper_95678-448.jpg' …
2023-08-22 11:25:52 - WELCOME DIALOG: bannerImage is not available, using alternative image

This one actually takes some time. It's not a lot but it is a delay. Could those lines be wrapped in an if [[ ! welcomeDialog = "false" or some such.

dan-snelson commented 11 months ago

Thanks, @Honestpuck!

brandingBanner is used in both the so-called "Welcome" dialog, as well as the main SYM dialog.