setusoft / silhouette-play-react-seed

A Silhouette Seed template which shows how Silhouette can be used to create a SPA with React/Redux and Play
MIT License
68 stars 21 forks source link

How to inject Silhouette environment into 'app-admin' module #46

Closed mrwillis closed 6 years ago

mrwillis commented 6 years ago

Hi,

I noticed that this project has a place for you to put your own code, namely in app-admin. I noticed that it's another module and thus needs to handle its own injection. My question is how can I get the silhouette environment created in the auth module in into my admin? Should I just follow the pattern and use Guice to make a new one?

Thanks.

Enalmada commented 6 years ago

This sample has really inspired me to change over my play/silhouette project from jquery to react. I am so grateful for the thought that went into the best way to get the best benefits of play backend and modern hot swapping js frontend. While firing it up I experienced a bit of the same uncertainty about how to extend the empty sections with my own code. Could I request what is hopefully just a moment of effort into the following:

akkie commented 6 years ago

@Enalmada Thanks for the great feedback! I share your concerns, but the limiting factor here is time. The project is open to contributions.

In a current project I develop for my employer, I have moved most of the Silhouette bindings, dependencies and configuration into the core project. So it's easier to share it between the other projects. @mrwillis You should do the same.

mrwillis commented 6 years ago

Thanks akkie. That seems like a sensible idea. I will try that