search

setvisible / ArrowDL

ArrowDL (Arrow Downloader) is a download manager for Windows, MacOS and Linux
https://www.arrow-dl.com/
GNU Lesser General Public License v3.0
553 stars 30 forks source link

[Fedora KDE] DownZemAll doesn't quit when right clicking tray icon and selecting "Quit" #14

Closed pizzadude closed 3 years ago

pizzadude commented 3 years ago

Hi, thanks for this program. I have been looking for a replacement for the old DownThemAll extension. Seems to work fine in Fedora KDE with Brave Browser. I had to manually edit the json file to get it to work though.

One issue I noticed is that DownZemAll doesn't quit when right clicking tray icon and selecting "Quit", or when pressing Ctrl + Q. The process stays running. Currently I have to manually kill the program when I want to quit it.

Other than that, the program works well. Thanks!

setvisible commented 3 years ago

Hi, Thanks for your feedback.

Do you mention the manifest.json for Brave? If so, and if it's ok for you, could you publish the changes?

For the bug at close time, does it happen every time ? Or sometimes ? Does it happen when a download is currently running? Is the queue containing a lot of downloads?

The closeEvent() triggers the write of the settings, queue and user preferences, so my initial guess is it's maybe due to a write permission, or too long write operations...

PS: I don't have Fedora so it's hard for me to reproduce this issue. I think I'll implement a 'debug log' or 'verbose' mode soon, in order to know what's happen. That is, it could be easier to investigate this issue

pizzadude commented 3 years ago

For the the manifest.json, I had to change the name of the file to "com.setvisible.downrightnow.json", and set the path to where I put DownZemAll inside the json. The json goes into "~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/".

For the bug, it happens all the time. For the process to exit I have to kill the program from the terminal.

LinuxCuba commented 3 years ago

Confirm in KDENeon this bug it happens all the time. For the process to exit I have to kill the program from the terminal. and ubuntu 18.04/20.04, the program not close. I'm updated the version to 2.0.6, and problem persist. Other issue is the extension is not install in firefox 80.0.1 the last version. And not update.

LinuxCuba commented 3 years ago

Confirm in KDENeon this bug it happens all the time. For the process to exit I have to kill the program from the terminal. And ubuntu 18.04/20.04, the program not close. I'm updated the version to 2.0.6, and problem persist. Other issue is the extension is not install in firefox 80.0.1 the last version. And not update. This problem is because the extension is no signed. Mozilla demands all extension signed actually. Please sign this. 2020-09-07_17-14

setvisible commented 3 years ago

Hi, I installed a virtual machine with KDE Neon, and I could reproduce the bug. So I'm currently investigating the issue and tell you if some progress. Regards

setvisible commented 3 years ago

The issue is the System Tray icon (notification area). For some reason it goes wrong with KDE.

Workaround:

Go to Options > Preferences > Interface Disable "Show system tray icon"

The application should close correctly.

pizzadude commented 3 years ago

Confirmed fixed in latest version.

LinuxCuba commented 3 years ago

The issue is the System Tray icon (notification area). For some reason it goes wrong with KDE.

Workaround:

Go to Options > Preferences > Interface Disable "Show system tray icon"

The application should close correctly.

yes, is closed, but, not show anymore the system tray icon, this not correct behavior.

LinuxCuba commented 3 years ago

Add option to keep in the system tray when closing, not only when minimizing, if you want it not to close and keep running. Close window, do not close the program.