setycz / ChickensMod

Just a lot of chickens
MIT License
14 stars 32 forks source link

Add in animania compat for special chickens #141

Open mser7 opened 5 years ago

mser7 commented 5 years ago

Issue Description:

Note: If this bug occurs in a modpack, please report this to the modpack author. Otherwise, delete this line and add your description here. If this is a feature request, this template does not apply to you. Just delete everything.

Steps to reproduce (important):

  1. Hold an item that is need to obtain special chicken when right-clicking on a vanilla chicken(book, tnt...)
  2. Right-click on an Animania chicken

What happens:

Nothing happened

What you expected to happen:

The animania chicken will then be transformed into a corresponding special chicken with the item(smart chicken, funwaychick...)


Affected Versions (Do not use "latest"):

GenDeathrow commented 5 years ago

Animania mod last I checked doesn't extend of normal chickens. Im only opposed to doing this because it means hard coding things that could change later would break worlds or cause issues. I understand its frustrating. If anything I may add a whitelist config option to list what entities can be used for it.

mser7 commented 5 years ago

https://github.com/capnkirok/animaniamod/issues/277

mser7 commented 5 years ago

Why don't you make it so special chicken's egg can be crafted from normal eggs instead of the whitelist system? Animania chickens also lay vanilla eggs

GenDeathrow commented 5 years ago

You can already use mods to create custom recipes to do this. The special chickens mechanic is as it should be.

Shybella commented 5 years ago

Hey, good thing I found this before cluttering your Discord.

Entity whitelist would be ideal in this case. I could just add the animania chicken( or any modded chicken ) and be done or even in special situations do something completely else.

I was originally looking for this option and didn't see it. I wouldn't hard code this either, adding the entity to a whitelist config is good enough.