Closed virtualritz closed 1 year ago
Thanks for the PR! :smile:
As I just mentioned in #86, there is the ongoing UI rewrite. But fortunately, most of the changes in your PR are in the node definitions and will work out of the box in the ui_next
branch. I'll make sure to copy over the consistent capitalization for the remaining bits!
I'll merge once CI passes, I'm assuming there won't be any issues EDIT: Ooops, just as I wrote it rustfmt errored out. Make sure to run cargo fmt
and push your branch :+1:
I did the rustfmt
last week, in case that fell through the cracks.
Ooops, sorry! Thanks for pointing that out :) Merging now!
Make
prefix, but most do not. So I removed it everywhere. This needs more work but rules should be put down first; not least for other developers eventually writing nodes (e.g. use of verbs vs. nouns, use of plural vs. singular etc.)New
andQuit
entries.Save As…
/Load
(platform standards on Windows, macOS & all Linux desktops that have human interface guidelines).Load
toOpen
.Open…
.Help
toWindow
.Diagnostics
.Diagnostics
toggle button to checkbox.