search

setzer22 / egui_node_graph

Build your node graph applications in Rust, using egui
MIT License
715 stars 134 forks source link

Will blackjack use egui_node_graph ? #9

Closed rsaccon closed 2 years ago

rsaccon commented 2 years ago

The reason I am asking : After playing and extending a bit the provided egui_node_graph_example I started to dive into the next stage: Adapting a minimal version of the blackjack PolyAsm based graph compiler, so I can do node traversal and finally get some executable instructions. Unfortunately this is a bit outside my comfort zone and I ran into an error about wrong lifetimes and at several places I was not comfortable what I was doing to get things to compile and I was also in doubt how to adapt blackjack NodeData to egui_node_graph Node<NodeData>.user_data.

Anyway, if you plan to make blackjack use egui_node_graph, then I probably could figure out myself how to get my minimal compiler example to work, otherwise a minimal working example of something like a graph compiler would be great.

setzer22 commented 2 years ago

Anyway, if you plan to make blackjack use egui_node_graph, then I probably could figure out myself

Yes! This refactor is already in progress. Feel free to follow progress on the feature/use_egui_node_graph branch :smile:

Also, feel free to ask any specific questions you may have in the meantime :smile: In fact, I just decided to open a forum using github Discussions, so feel free to post questions on the Q&A category there :+1:

rsaccon commented 2 years ago

Thanks a lot. Gonna study that branch now ! Closing this.

setzer22 commented 2 years ago

Note that the branch is still a work-in-progress. The part for the graph compiler is not yet up, but I think I can get it done later today

setzer22 commented 2 years ago

Hey @rsaccon! Here's the PR swapping the old code in blackjack with egui_node_graph. The code is almost there, and I just need to take care of some unrelated thing before the merge. Feel free to have a look: https://github.com/setzer22/blackjack/pull/18

rsaccon commented 2 years ago

thanks a lot. I actually managed already yesterday to get a minimal compiler working based on your mind blowing elegant PolyAsm hECS thing you have in blackjack. Will update to latest egui_node, and once I have cleaned up the messy things in my experiment, hopefully have something to show ...

setzer22 commented 2 years ago

Happy to hear that! 😄 What project are you working on, by the way? If you build something nice, feel free to open an issue about it so I can showcase it on the README!

rsaccon commented 2 years ago

A NURBS based 3d modeling app based on truck CAD kernel, which still is very alpha status. But right now I am just experimenting with different approaches, like scripting the 3d models in rhai, node graph and I would like to combine node graph editing with direct modeling, but no idea where this journey will bring me. Will post here when I have something to share