seu-as-code / seu-as-code.plugins

The Gradle plugins for SEU-as-code.
Apache License 2.0
28 stars 10 forks source link

Add Mac support to credentials plugin #25

Closed lreimer closed 7 years ago

lreimer commented 8 years ago

Add support for the Mac OS keychain.

lreimer commented 7 years ago

Need to do some major refactoring on how the credentials are represented and accessed in the plugin.

Also need to build a common API for both Windows and Mac, both are quite different.

lreimer commented 7 years ago

Initial development is done. Will do some integration testing now and then publish the plugin to Bintray and Gradle plugin repo.

lreimer commented 7 years ago

Integration testing went OK. Still, on MacOS a few minor issues occurred when accessing the default keychain from different processes.

So I will add a new configuration convention where you can set the actual keychain or security file location, something like

credentials {
   keychain = '/Users/seu-as-code/Library/Keychain/seu-as-code.keychain'
}
lreimer commented 7 years ago

May need to interpolate the keychain string with environment variables or system properties to make things more convenient. But this can be handled by standard Groovy functionality I think.

lreimer commented 7 years ago

So far initial integration testing looks good. Will wait a little longer and than release final version of the plugin.

ghost commented 7 years ago

Your issue doesn't follow our guidelines. Please fix the following:

Click here for details.

Thank you! :pray: This comment was made by GitMagic – Magically enforcing your contribution guidelines.

ghost commented 7 years ago

Thank you, everything looks good now! :bowtie: