search

seung-lab / cloud-files

Threaded Python and CLI client library for AWS S3, Google Cloud Storage (GCS), in-memory, and the local filesystem.
BSD 3-Clause "New" or "Revised" License
36 stars 8 forks source link

Deprecation notice about urllib3[secure] #77

Closed fyunusa closed 1 year ago

fyunusa commented 1 year ago

Description

pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12) https://github.com/urllib3/urllib3/issues/2680

uremoved urllib3[secure] extra updated with urllib3

william-silversmith commented 1 year ago

Thanks! It looks like the package minimum version needs to be adjusted to 1.26.12 though. Prior to that, the incorrect behavior will occur.

pquentin commented 1 year ago

@william-silversmith While upgrading cannot hurt, you don't need to. We recommended removing that secure extra for some time (requests did it last year). The only change in 1.26.12 is to print a warning.

william-silversmith commented 1 year ago

That sounds peachy then. For reference, it looks like urllib3 changed from supporting PyOpenSSL to using a python default module, which is why the flag is no longer necessary.

sethmlarson commented 1 year ago

@william-silversmith Saw that https://github.com/seung-lab/cloud-volume/pull/552 got merged, is this one good to go as well?

william-silversmith commented 1 year ago

Thanks for the PR all!