seung-lab / cloud-volume

Read and write Neuroglancer datasets programmatically.
https://twitter.com/thundercloudvol
BSD 3-Clause "New" or "Revised" License
131 stars 47 forks source link

bug in saving precomputed meshes: unexpected keyword argument 'fuse' #600

Closed jefferis closed 3 months ago

jefferis commented 12 months ago

Hi @william-silversmith. Hope all is good! I'm seeing a new (to me) error with cloudvolume 8.25.0 although 8.24.2 also gives this for @schlegelp.

This is from R but the python code should be obvious:

vol = cv$CloudVolume("precomputed://gs://manc-seg-2022-05/manc-seg-2022-05", use_https=TRUE)
vol$mesh$save(10118L, file_format='obj')

gives

── Python Exception Message ──────────────────────────────────────────────────────────────
Traceback (most recent call last):
  File "/Users/jefferis/Library/r-miniconda/envs/r-reticulate/lib/python3.8/site-packages/cloudvolume/datasource/precomputed/mesh/unsharded.py", line 295, in save
    mesh = self.get(segids, fuse=True, remove_duplicate_vertices=True)
TypeError: get() got an unexpected keyword argument 'fuse'

── R Traceback ───────────────────────────────────────────────────────────────────────────
    ▆
 1. └─fafbseg::read_cloudvolume_meshes("10118", cloudvolume.url = "precomputed://gs://manc-seg-2022-05/manc-seg-2022-05")
 2.   └─fafbseg::save_cloudvolume_meshes(...) at fafbseg/R/cloudvolume-reticulate.R:207:2
 3.     └─vol$mesh$save(10118L, file_format = "obj") at fafbseg/R/cloudvolume-reticulate.R:93:4
 4.       └─reticulate:::py_call_impl(callable, call_args$unnamed, call_args$named)
william-silversmith commented 3 months ago

Hi Greg, so sorry I missed this until now! I just pushed a fix that should be in the next release.

jefferis commented 3 months ago

Thanks @william-silversmith !

william-silversmith commented 3 months ago

The next release is out! Should be fixed.