search

seung-lab / kimimaro

Skeletonize densely labeled 3D image segmentations with TEASAR. (Medial Axis Transform)
GNU General Public License v3.0
136 stars 23 forks source link

support python3.8? #51

Closed xiuliren closed 4 years ago

xiuliren commented 4 years ago

I have accidentally add python3.8 in master directly (was indented to create a PR). https://github.com/seung-lab/kimimaro/commit/e287605a2869269d3ac834ea036238de37ec2bd1

Python 3.8 is the latest release, so we should support it? My chunkflow is using python3.8, it seems that there is an error in python3.8 build due to kimimaro. The build was good a few days ago, so the problem should come from a recent change of kimimaro.

https://travis-ci.org/github/seung-lab/chunkflow/builds/700591119

xiuliren commented 4 years ago

the build failed for python3.8 https://travis-ci.org/github/seung-lab/kimimaro/jobs/701101312

cnzqy1 commented 4 years ago

I think something specifically in version 1.6.0 is breaking the Python 3.8 build. I was installing Igneous and pip collected kimimaro 1.6.0 which failed to build, and had to specify kimimaro==1.5.0 in requirements.txt to get around this issue.

william-silversmith commented 4 years ago

Looks like the python3.8 needed an updated cython to generate good code. I'll make a PR with working code and make a new release. Thanks for letting me know!