search

seung-lab / kimimaro

Skeletonize densely labeled 3D image segmentations with TEASAR. (Medial Axis Transform)
GNU General Public License v3.0
136 stars 23 forks source link

call kimimaro.skeletontricks.roll_invalidation_ball_inside_component using positional-only arguments #87

Closed jasonkena closed 5 months ago

jasonkena commented 5 months ago

https://github.com/seung-lab/kimimaro/blob/c9e58f677d522d7b7f3c72c75d9fa768bb5e5e71/ext/skeletontricks/skeletontricks.pyx#L372 https://stackoverflow.com/questions/68380123/cythonized-function-with-a-single-positional-argument-is-not-possible-to-call-us

Cython by default does not allow positional arguments to be specified in a kwargs-like style. This fix stops kimimaro.skeletonize from raising TypeError: roll _invalidation_ball_inside_component() takes at least 6 positional arguments, which is introduced in https://github.com/seung-lab/kimimaro/pull/86

william-silversmith commented 5 months ago

Thank you for this!