Increase 32-bit X Representation Space to 1023 Voxels

seung-lab / zmesh

Marching Cubes & Mesh Simplification on multi-label 3D images.

GNU General Public License v3.0

58 stars 8 forks source link

Increase 32-bit X Representation Space to 1023 Voxels #4

Closed william-silversmith closed 2 years ago

william-silversmith commented 5 years ago

For some reason, the last bit of the X representation in 32-bit mode is overflowing in marching_cubes.hpp. This prevents us from using all 11 bits, so we are limited to 511 voxels in the X dimension. There's a few ways this could happen:

Two vertices interact using addition and it triggers a carry / overflow.
Mysterious conversion from uint32 to int32.

william-silversmith commented 2 years ago

Fixed in 3eb9e0b1e68e9b60479fa4c0fae410b22e6798e3