Flags.docidfield and Flags.contentsfields not used consistently

[GoogleCodeExporter]

The refactoring to make these configurable is quite incomplete:

DocVectors.java line 160: if (this.indexReader.document(i).getField("path")
!= null) {

BuildPositionalIndex 135: String[] fieldsToIndex = {"contents"};

etc. (see
http://www.google.com/codesearch?hl=en&start=10&sa=N&filter=0p&q=%28\%22path\%22
%29|%28\%22contents\%22%29+package:http://semanticvectors\.googlecode\.com)

Original issue reported on code.google.com by jens.gri...@gmail.com on 9 Feb 2010 at 6:00

[GoogleCodeExporter]

You're quite right. I fixed these and another one I found. This means that 
there may
be more, I haven't checked thoroughly. I'm marking the issue "Fixed", and we'll 
ship
the fix with the next version of SV. But if anyone find any more of these, 
please
reopen this bug at once. 

Original comment by widd...@google.com on 9 Feb 2010 at 7:10

• Changed state: Fixed

[GoogleCodeExporter]

It seems that there are still quite a few left.

http://www.google.com/codesearch?hl=en&sa=N&filter=0p&q=%28\%22path\%22%29|%28\%
22contents\%22%29+package:http://semanticvectors\.googlecode\.com

gives 16 results, many of which are hardcoded field names...

Original comment by jens.gri...@gmail.com on 10 Feb 2010 at 10:27

[GoogleCodeExporter]

I've made further fixes in revisions 359 and 360.

There are some hard-coded strings left in tests and index-building utilities, I 
think
these are OK, so I'm marking this as fixed.

Original comment by widd...@google.com on 14 Apr 2010 at 5:16