Closed GoogleCodeExporter closed 9 years ago
Sounds good to me. Don't worry about backwards compatibility, you'd be doing
the right thing.
Original comment by widd...@google.com
on 28 Oct 2010 at 8:13
Checked in changes in TermVectorsFromLucene and TermTermVectorsFromLucene to
add new constructors which do not silently use parameters from Flags.
Checked in changes to BuildBilingualIndex, BuildIndex, and BuildPositionalIndex
to use the new constructors.
Original comment by johann.petrak@gmail.com
on 25 Nov 2010 at 10:23
Thanks so much, Johann. Looks good to me.
Original comment by widd...@google.com
on 27 Nov 2010 at 12:50
Unfortunately this proved unwieldy because it became too easy to create
incompatible vectors and vector stores. Reverted to using the Flags.dimension
global value as far as possible, except in the new vectors package itself.
However, this is unfortunately leading to problems of its own. Comments and
suggestions welcome.
Original comment by widd...@google.com
on 25 Jul 2011 at 2:37
Changed back again to pass vectortype and dimension in and try to use them as
little as possible in internal classes. Pretty much done and tested and
verified, but I still think there is much room for improvement in our
configuration approach.
Original comment by widd...@google.com
on 26 Aug 2011 at 7:03
Original issue reported on code.google.com by
johann.petrak@gmail.com
on 28 Oct 2010 at 7:58