seunginah / semanticvectors

Automatically exported from code.google.com/p/semanticvectors
0 stars 0 forks source link

patch for lucene3.6.1 #60

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I made a patch for trunk to be compatible with Lucene 3.6.1

Original issue reported on code.google.com by FJS...@gmail.com on 28 Sep 2012 at 10:17

Attachments:

GoogleCodeExporter commented 9 years ago
That's cool, thankyou.

Were these the only changes you need to make? (If you have the time, please try 
running "ant testall" and see what happens.) If that works, please let me know 
if you want commit permissions to go ahead and submit your patch - I think the 
main development trunk should stay up-to-date with most recent Lucene versions 
whenever possible.

I haven't read these .diff files before properly but it looks simple enough, so 
if you want I could factor out the necessary code, test and submit.

Thanks again, Dominic

Original comment by dwidd...@gmail.com on 28 Sep 2012 at 3:56

GoogleCodeExporter commented 9 years ago
I've tested out this fix and it works fine. (That was easy, thanks.) Checked in 
as revision 767 (https://code.google.com/p/semanticvectors/source/detail?r=767).

The big delay has been in trying out updating to Lucene 4.0, which turns out to 
be more work than I anticipated. In the meantime, the Lucene project seems to 
be promoting 3.6.2 in general availability and 4.0.0 concurrently. So I think 
it's worth releasing the 3.6.2 fix at least, which I'll proceed to do.  

Original comment by dwidd...@gmail.com on 14 Jan 2013 at 9:23