search

seunglee98 / fedmatch

Other
27 stars 10 forks source link

Typo in documentation for clean strings - doesn't remove replacements. #9

Closed c0webster closed 2 years ago

c0webster commented 2 years ago

Right now, replacements aren't removed, which is inconsistent with the documentation. For example:

teststring <- c("apple corp", "apple corporation", "banana tech", "banana technology"); teststring [1] "apple corp" "apple corporation" "banana tech"
[4] "banana technology" lean_strings(teststring, remove_words=TRUE, common_words = fedmatch::corporate_words) [1] "apple" "apple corporation" "banana"
[4] "banana technology" clean_strings(teststring, remove_words=TRUE, common_words = fedmatch::corporate_words, remove_char = fedmatch::corporate_words[[2]]) [1] "apple" "apple" "banana" "banana"

c0webster commented 2 years ago

decided in meeting 11/5/2021 to actually just change the documentation

c0webster commented 2 years ago

decided again in meeting 11/8 to actually remove the replacements.