search

seunlanlege / vscode-action-buttons

VsCode extension for custom status bar buttons
89 stars 25 forks source link

singleInstance no longer works in v 1.2.0 #60

Closed mbenkmann closed 2 years ago

mbenkmann commented 3 years ago

Just updated to v 1.2.0 of ActionButtons and buttons with singleInstance:true only work once. The 2nd time I use the button I get and error popup "Running the contributed command: 'extension.Clean' failed." where Clean ist the name of the button. The command in question is simple call to make.

            "cwd": "${workspaceFolder}",    
            "name": "Clean",
            "color": "white",
            "singleInstance": true, 
            "command": "make -C arm clean",
JakobMiesner commented 3 years ago

Same here

AlexandreMarkus commented 3 years ago

same #59

AlexandreMarkus commented 2 years ago

@seunlanlege

seunlanlege commented 2 years ago

Tbh I don't personally use this code anymore, so I'm happy to merge PRs and make releases but I don't have time to fix bugs.

ahehn commented 2 years ago

Hi @seunlanlege , please consider pull request #62, which solved the issue for me. Thank you and BR

ahehn commented 2 years ago

Thank you, @seunlanlege. Would you mind making a release, so we can use the fix? 👼

seunlanlege commented 2 years ago

published v1.2.1

ahehn commented 2 years ago

Thank you!! 🥳