seunomosowon / TA-connectivity

This is a Splunk application which adds 3 modular inputs for testing the availability of servers, web applications or other applications.
Other
4 stars 4 forks source link

Parse more ping information #1

Closed MoshiMoshi0 closed 7 years ago

MoshiMoshi0 commented 8 years ago

Recently found this app and im finding it quite useful but it seems that pinger.py does not parse all of rtt/packet information.

For windows it just parses average rtt and packet loss. For linux it parses packet loss and time that the ping command took, not the average rtt, which is a bug itself caused by using small packet size (the ping command does not output full rtt information for small packet size).

So I tweaked the code to include full rtt information (avg, min, max, mdev) and packet information (sent, received, loss). You can find new pinger.py file here. The code is only tested on linux. Forgive me any bugs as I dont use python and I dont have splunk dev setup.

I hope you will incorporate those changes. If needed I can make a pull request .

seunomosowon commented 8 years ago

Nice! I'll incorporate the changes and see if I can test on windows/Mac.

I've only heard from one other person, but it's good to hear that you found it useful.

Thanks again. On Fri, 21 Oct 2016 at 01:22, devcompl notifications@github.com wrote:

Recently found this app and im finding it quite useful but it seems that pinger.py does not parse all of rtt/packet information.

For windows it just parses average rtt and packet loss. For linux it parses packet loss and time that the ping command took, not the average rtt, which is a bug itself caused by using small packet size (the ping command does not output full rtt information for small packet size).

So I tweaked the code to include full rtt information (avg, min, max, mdev) and packet information (sent, received, loss). You can find new pinger.py file here http://pastebin.com/ZKUeWZAL. The code is only tested on linux. Forgive me any bugs as I dont use python and I dont have splunk dev setup.

I hope you will incorporate those changes. If needed I can make a pull request .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/seunomosowon/TA-connectivity/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_Zs7Mnk2ltSTwzokxcB5qBYVmqbrcpks5q2AXFgaJpZM4KcvXb .