search

seunomosowon / TA-mailclient

This technology adapter add-on fetches emails for Splunk to index from mailboxes using either POP3 or IMAP, with or without SSL.
Apache License 2.0
9 stars 10 forks source link

Minor fixes #21

Closed edro15 closed 3 years ago

edro15 commented 3 years ago

Fixes issues #19 and #20.

Changelog:

seunomosowon commented 3 years ago

Have a look at jobs 230.3 and 230.4: https://travis-ci.com/github/seunomosowon/TA-mailclient/builds/211073663

seunomosowon commented 3 years ago

It’s actually fine, it just needs a spec to avoid fhe warning. It’s a setting that is included in v8, and ignored in v7. You can optionally force your v7.3 to use Python 3 for all scripts, but this is not the intent in this app. The modular input works with both Python 2.7 and Python 3.

Easy to take out the warning with a spec file.

Cheers, Seun

On Tue, 29 Dec 2020 at 13:49, Erica Pescio notifications@github.com wrote:

@edro15 commented on this pull request.

In default/server.conf https://github.com/seunomosowon/TA-mailclient/pull/21#discussion_r549711448 :

@@ -0,0 +1 @@ +python.version = python3

Just pulled the latest version (1.5.2) from Splunkbase. This is what Splunk 7.3 logs at restart:

$ sudo /opt/splunk/bin/splunk restart Stopping splunkd... Shutting down. Please wait, as this may take a few minutes. .. [ OK ] Stopping splunk helpers... [ OK ] Done.

Splunk> Now with more code!

Checking prerequisites... Checking http port [8000]: open Checking mgmt port [8089]: open Checking appserver port [127.0.0.1:8065]: open Checking kvstore port [8191]: open Checking configuration... Done. Checking critical directories... Done Checking indexes... Validated: _audit _internal _introspection _telemetry _thefishbucket history mail main summary Done Checking filesystem compatibility... Done Checking conf files for problems... Invalid key in stanza [mail] in /opt/splunk/etc/apps/TA-mailclient/default/inputs.conf, line 2: python.version (value: python3). Your indexes and inputs configurations are not internally consistent. For more information, run 'splunk btool check --debug' Done Checking default conf files for edits... Validating installed files against hashes from '/opt/splunk/splunk-7.3.0-657388c7a488-linux-2.6-x86_64-manifest' All installed files intact. Done All preliminary checks passed.

Starting splunk server daemon (splunkd)... Done [ OK ]

Waiting for web server at http://127.0.0.1:8000 to be available... Done

If you get stuck, we're here to help.Look for answers here: http://docs.splunk.comThe Splunk web interface is at http://so1:8000

As you can see, there's still this message Invalid key in stanza [mail] in /opt/splunk/etc/apps/TA-mailclient/default/inputs.conf, line 2: python.version (value: python3). You can verify this error in Splunk with this SPL index=_internal sourcetype=splunkd_stdout python.version.

additional_folders parameter seems to be working now. Thanks for the change.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/seunomosowon/TA-mailclient/pull/21#discussion_r549711448, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5TM2ZRBTPQJKJD57OKN3SXHM7ZANCNFSM4VMCINYQ .

edro15 commented 3 years ago

Already fixed in PR #22 . Thanks for the useful discussion @seunomosowon

seunomosowon commented 3 years ago

It’s been my pleasure.

On Mon, 4 Jan 2021 at 13:51, Erica Pescio notifications@github.com wrote:

Already fixed in PR #22 https://github.com/seunomosowon/TA-mailclient/pull/22 . Thanks for the useful discussion @seunomosowon https://github.com/seunomosowon

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seunomosowon/TA-mailclient/pull/21#issuecomment-753985999, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5TM35STKHVDYP2UYOHKTSYHBXDANCNFSM4VMCINYQ .