seuros / capistrano-puma

Puma integration for Capistrano
https://github.com/seuros/capistrano-puma
MIT License
616 stars 300 forks source link

Release 6.0.0 #371

Closed TeamNautilus closed 5 months ago

TeamNautilus commented 9 months ago

Hi,

I have a Rails 7.1.2 project, with Puma 5.6.5 and the capistrano3-puma at 5.2.0. Now, I want to upgrade Puma to 6.4.2 but this involves a regression of capistrano3-puma at 1.2.1. However, if I force capistrano3-puma at 6.0.0.beta.1, all is good.

So, the questions are:

Thanks Team Nautilus

salex commented 9 months ago

I've had some issues over the last year when I moved to 7.0.x then 7.1.x.

Just had another one today trying to deploying an app to a local server. Puma wouldn't restart. The app had not been updated since rails 7.0 about 2 years ago. This had to do with (I think!) the puma systemd plugin.

I fixed it by remembering that the 6.0.0.beta.1 won't be updated until you move you puma version to gem puma, ~> 6.0. I have it running on 3 production app without any problem. My current puma version is puma (6.4.2)

There is not much action on the site - mainly because it fairly stable.

daralbrecht commented 8 months ago

Hey!

Just checking in on the capistrano-puma project and noticed it's been a bit since the last update. Are there any plans to keep things moving or merge the beta for 6.0.0? Really appreciate all the effort that goes into this and just curious about what's next. Thanks for all the awesome work!

ccastillop commented 8 months ago

Hello. I tested with Rails 7.1 and Puma 6.4.2, to be deployed with systemd on a Ubuntu server. I found that the template for creating the service evaluates Gemfile to find sd_notify gem If not, the Type=simple notification is set.

Reading further, This is because Puma itself has built-in support for systemd's notify protocol since version 5.1.

Maybe a fix is needed on this line to verify if the puma version is greater than 5.1

github-actions[bot] commented 6 months ago

Stale issue message