sevagh / pitch-detection

autocorrelation-based O(NlogN) pitch detection
MIT License
577 stars 67 forks source link

Implement SWIPE #66

Closed sevagh closed 5 years ago

sevagh commented 5 years ago

https://pdfs.semanticscholar.org/0fd2/6e267cfa9b6d519967ea00db4ffeac272777.pdf

sevagh commented 5 years ago

Dunno if I care about this - pYIN + CREPE are good enough.

sevagh commented 5 years ago

Fuck it, why not.

sevagh commented 5 years ago

https://github.com/kylebgorman/swipe

sevagh commented 5 years ago

I have a branch here: https://github.com/sevagh/pitch-detection/tree/feat/SWIPE This is the above C code, transliterated to use C++. I can't figure out what the output is supposed to represent:

swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
swipe: nan
sevagh commented 5 years ago

Implemented FFTW->FFTS issues in my fork of SWIPE. Now I have to vet the custom vector -> std::vector changes, something else is wrong here.

sevagh commented 5 years ago

Closed by https://github.com/sevagh/pitch-detection/pull/74