search

sevagh / pitch-detection

autocorrelation-based O(NlogN) pitch detection
MIT License
577 stars 67 forks source link

Upkeep/christmas updates: bugfixes and more #87

Closed sevagh closed 10 months ago

sevagh commented 10 months ago

I know my sine code is buggy (see https://github.com/sevagh/pitch-detection/issues/72)

I can use librosa's tone function to generate a txt file with vector values for testing sinewaves.

sevagh commented 10 months ago

For posterity

I know my sine code is buggy (see https://github.com/sevagh/pitch-detection/issues/72)

The sine wave was not the buggy one, but in fact the effect of a power-of-two size on the autocorrelation function (through a strange behavior of ffts in https://github.com/anthonix/ffts/issues/65)