sevagh / xumx-sliCQ

music demixing with the sliCQ Transform and PyTorch
MIT License
26 stars 6 forks source link

Final block in forward NSGT is not inverse FFT'd #13

Closed mattpitkin closed 10 months ago

mattpitkin commented 1 year ago

I've noticed that due to the way the contents of the if statement here https://github.com/sevagh/xumx-sliCQ/blob/v2/xumx_slicq_v2/nsgt/nsgtf.py#L66 are setup, the final frequency block of coefficients for the forward transform never get inverse FFTd (the last block gets appended by then will not enter that statement again for the ifft to be performed). This is inconsistent with your other your implementation in https://github.com/sevagh/nsgt/blob/main/nsgt/nsgtf.py, so I guess is something that needs fixed.