search

sevdokimov / log-viewer

Web UI for viewing logs
Apache License 2.0
434 stars 103 forks source link

Building zip #154

Closed ghost closed 2 months ago

ghost commented 1 year ago

How do you build the zip, clean install gives

[INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-artifacts) on project log-parent: Execution sign-artifacts of goal org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign failed.: NullPointerException -> [Help 1]

Package does nothing.

sevdokimov commented 1 year ago

Maven tries to sign jar (all jar in the Maven Central Repositories must be sign) You can disable it, just disable "sign" profile: mvn -P !sign clean install

ghost commented 1 year ago

Thanks, another quick one I want to introduce some extra security features. Do I create a branch of 1.0.3?

sevdokimov commented 1 year ago

yes, or you can create a pull request to master

ghost commented 1 year ago

So when I run package the root shows not zip

ghost commented 1 year ago

I just see staff 96 Jan 3 18:58 javadoc-bundle-options

ghost commented 1 year ago

Any thoughts on why this is not building?

sevdokimov commented 1 year ago

package works fine on my machine, zip appears in log-viewer-cli/target/log-viewer-1.0.4-SNAPSHOT.zip Do you see any error message?