search

sevdokimov / log-viewer

Web UI for viewing logs
Apache License 2.0
477 stars 105 forks source link

Add saving the log to a file via logback #184

Closed dima-bzz closed 1 year ago

sevdokimov commented 1 year ago

Sorry, I was wrong. :-) log-viewer-cli/bin is a good location for logback.xml. log-viewer-cli/bin contains files that will be packed into the archive. I was confused, I thought "/bin" is a directory inside the archive, not a directory in sources. Please, revert the last 2 commits. Probably log-viewer-cli/bin should be renamed to log-viewer-cli/assets

dima-bzz commented 1 year ago

@sevdokimov Or maybe just download java and don't add it to $PATH. Therefore, it is very difficult to predict. I believe that we just provide a template, and users will customize themselves according to their requirements.

sevdokimov commented 1 year ago

@sevdokimov Or maybe just download java and don't add it to $PATH. Therefore, it is very difficult to predict. I believe that we just provide a template, and users will customize themselves according to their requirements.

/bin directory is in $PATH , so calling java covers the case when we need to call /bin/java. Calling java covers more cases then /bin/java.

dima-bzz commented 1 year ago

@sevdokimov We can replace the absolute path with a relative one. But I did not check this solution, since java is not registered in my $PATH and I have the full path specified.

dima-bzz commented 1 year ago

@sevdokimov Alternatively we can make an installation script

dima-bzz commented 1 year ago

@sevdokimov I thought that this is a console launch and there is no need for output to a file.

sevdokimov commented 1 year ago

@sevdokimov I thought that this is a console launch and there is no need for output to a file.

Agree

sevdokimov commented 1 year ago

Please, resolve the conflicts.