seveas / git-spindle

Abandoned command-line interface to GitHub and other central git services
Other
172 stars 35 forks source link

merge-request: No merge request message specified #101

Closed raine closed 8 years ago

raine commented 8 years ago
  1. $ git lab merge-request
  2. vim is opened with commit message as placeholder
  3. save the file and exit
  4. output says "No merge request message specified"
seveas commented 8 years ago

Was the commit message a single line?

raine commented 8 years ago

Yes.

seveas commented 8 years ago

Yeah, git-spindle requires you to specify a title and body for a merge request. That won't change, but the error message could be better.

raine commented 8 years ago

Okay, I'm used to not having to specify the body as that's how gh works and I do prefer that behavior.

kflorence commented 8 years ago

@seveas can body just default to an empty string?

raine commented 8 years ago

That would be great. 80% of the time I do this because there's nothing to expand upon.

blah blah

-
seveas commented 8 years ago

97b9483 adds the possibility to leave out a body for single-commit pull requests, if and only if that commit also only has a title.