search

seveas / python-networkmanager

Easy communication with NetworkManager
http://packages.python.org/python-networkmanager/
Other
163 stars 90 forks source link

Don't assume that the `dns` field is present in the `GetSettings` D-Bus reply #94

Closed michael-schaller closed 1 year ago

michael-schaller commented 2 years ago

This has changed for Network Manager >= 1.34 with commit https://github.com/NetworkManager/NetworkManager/commit/d652e0f53487cf3f5b1f64038d9ff4a2f5947213.

While we're at it also don't assume that any of the other fields are present.

Fixes #93.

seveas commented 2 years ago

Hi Michael!

Thank you for this pr. Unfortunately, I've mostly abandoned this project and have been trying to find someone to take over maintenance. Would you perhaps be interested?

michael-schaller commented 2 years ago

Hi Dennis,

Thanks for the honest reply. I'll ask my team what they wanna do...

Best,

Michael

enadgermani commented 2 years ago

Hi @seveas, is it possible for you to make this merge please? I'd like to help maintaining this lib but i don't have the skills yet, of course i can help.

seveas commented 1 year ago

Closing all PR's and issues prior to archiving this repository.