search

seven1m / bible_api

Ruby web app that serves JSON API for open and public domain bibles
https://bible-api.com
MIT License
578 stars 105 forks source link

Random verses api #107

Closed shedrack-okunda closed 1 month ago

shedrack-okunda commented 1 month ago

I am trying to call the random verse api and it does not return a thing in the browser

seven1m commented 1 month ago

Is this the URL you are using?

https://bible-api.com/?random=verse

shedrack-okunda commented 1 month ago

yes this one

On Tue, Sep 17, 2024 at 3:28 PM Tim Morgan @.***> wrote:

Is this the URL you are using?

https://bible-api.com/?random=verse

— Reply to this email directly, view it on GitHub https://github.com/seven1m/bible_api/issues/107#issuecomment-2355597861, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2L47OMSNB4KJNQJATPEZQLZXAN47AVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVGU4TOOBWGE . You are receiving this because you authored the thread.Message ID: @.***>

seven1m commented 1 month ago

OK, what happens when you use that URL? Do you get an error? Can you include a screenshot?

shedrack-okunda commented 1 month ago

I will do so actually what it does is this in post man it returns random verses but in the browser it is not returning anything that is when i put it in a try and catch it returns the error message

On Wed, 18 Sept 2024, 17:52 Tim Morgan, @.***> wrote:

OK, what happens when you use that URL? Do you get an error? Can you include a screenshot?

— Reply to this email directly, view it on GitHub https://github.com/seven1m/bible_api/issues/107#issuecomment-2358693734, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2L47OKAGSLXR2UHPILHEGTZXGHSXAVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYGY4TGNZTGQ . You are receiving this because you authored the thread.Message ID: @.***>

seven1m commented 1 month ago

Oh, I see the problem. We are not including the CORS header for this endpoint. I will fix this...

seven1m commented 1 month ago

This should work for you now!

shedrack-okunda commented 1 month ago

You have already fixed the CORS problem

On Fri, 20 Sept 2024, 05:31 Tim Morgan, @.***> wrote:

This should work for you now!

— Reply to this email directly, view it on GitHub https://github.com/seven1m/bible_api/issues/107#issuecomment-2362586195, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2L47OPUJWIVSPLSPY6ZRPLZXOCG7AVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGU4DMMJZGU . You are receiving this because you authored the thread.Message ID: @.***>

seven1m commented 1 month ago

I don't understand what you mean. I did indeed fix the CORS problem. Can you verify your original issue is now fixed?

shedrack-okunda commented 1 month ago

Thank you Let me verify and i will let you know

On Sun, 22 Sept 2024, 03:42 Tim Morgan, @.***> wrote:

I don't understand what you mean. I did indeed fix the CORS problem. Can you verify your original issue is now fixed?

— Reply to this email directly, view it on GitHub https://github.com/seven1m/bible_api/issues/107#issuecomment-2365381201, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2L47OI2B4W4API4QQGM6I3ZXYG6FAVCNFSM6AAAAABOK3UO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM4DCMRQGE . You are receiving this because you authored the thread.Message ID: @.***>