search

seven1m / bible_api

Ruby web app that serves JSON API for open and public domain bibles
https://bible-api.com
MIT License
557 stars 102 forks source link

Modern book names in translation queries #37

Open nivaca opened 4 years ago

nivaca commented 4 years ago

Currently to use the API to query for a translation, one has to use the target language's book names, e.g.:

http://bible-api.com/Joannes+3:16?translation=clementine

Whereas using the English names of those books does not work:

http://bible-api.com/John+3:16?translation=clementine

Could the API be fixed so it does work? (I usually don't recall the Latin names of all the books from the Vulgata).

Thanks.

seven1m commented 4 years ago

Thanks for the issue. It's been awhile since I worked on this, but I think the solution is to update this file: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/latin.rb

It should look something more like this one: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/portuguese.rb

If you are able to help, I would accept a PR over on the bible_ref repository! If not, I will get around to it someday...

nivaca commented 4 years ago

Sure, I'll give it a try. Best.