search

seven1m / bible_api

Ruby web app that serves JSON API for open and public domain bibles
https://bible-api.com
MIT License
538 stars 101 forks source link

Passage Mismatch Lookup #56

Closed johndoesniper closed 2 years ago

johndoesniper commented 2 years ago

Hi Tim,

I greatly appreciate the effort you've put in to this seamless API, but I wanted to bring it to your attention that as I looked up Philippians 4, I receive Philippians 1:4 instead. I'm not sure if the reference is a one off as all other scriptures I've tried were correct so I believe the data to be mostly accurate. If you see the error is on my part and how I may address it, do let me know. I've noted the same for WEB and KJV translations. Provided is the link I submit https://bible-api.com/Philippians 4, but should be expecting https://bible-api.com/Philippians 4:1-23 as the results. Regards.

seven1m commented 2 years ago

Sorry for the late reply. Thank you for reporting this.

Seems the issue is in this list of patterns: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/english.rb#L10

I believe it was supposed to match Philemon - not Philippians… 😬

That should be a list of book IDs anyway. 🤦‍♂️

seven1m commented 2 years ago

Fixed in 0c2053717448986868d27879e5c3a8e069588f31.