search

seven1m / bible_api

Ruby web app that serves JSON API for open and public domain bibles
https://bible-api.com
MIT License
538 stars 101 forks source link

Add support for Good News Bible #66

Closed nwaughachukwuma closed 2 years ago

nwaughachukwuma commented 2 years ago

Summary

This PR includes the texts for the Good News Bible in CSV format and I'm hoping it's good and robust enough. I'm able to work with you to bring things up to speed in whatever regard required. Do let me know what you think.

seven1m commented 2 years ago

Very cool! All our bible data is over on the https://github.com/seven1m/open-bibles repo, so please make a PR over there instead.

When you do move this over, please include a link for the source of where you got this file... Especially important is to find out what the license is, as we only use explicitly public domain or openly-licensed texts.

Last, CSV is ok, but I'm wondering if you have it in one of the existing XML formats (USFX, Zefania, or OSIS). If it only comes in CSV, that is fine, but the open-bibles repo is all XML currently, so adding a new different format wouldn't be preferred.

Thanks for your help! (I'm going to close this PR for now. I hope you will open it over on the open-bibles repo!)

nwaughachukwuma commented 2 years ago

Ok thanks...following-up

nwaughachukwuma commented 2 years ago

A new PR has been opened at https://github.com/seven1m/open-bibles/pull/12, for tracking