search

seven1m / bible_api

Ruby web app that serves JSON API for open and public domain bibles
https://bible-api.com
MIT License
538 stars 101 forks source link

Getting a whole chapter #75

Closed c-edh closed 1 year ago

c-edh commented 1 year ago

Hi, first of all I want to thank you for making this API available to the public for free!

I notice that there are a few chapters that wont fetch all the verses. For example trying to get all the verses for 3 John 1 it will only get one verse from the chapter. While 1 John 1 gets all the verses

seven1m commented 1 year ago

I am sorry about that, but I don't really have a good solution. Since 3 John is a single-chapter book, the chapter number is optional.

So just as 3 John 3 will return the third verse, 3 John 1 will return the first verse.

A bit more info here: https://github.com/seven1m/bible_api/issues/51#issuecomment-799456431

seven1m commented 1 year ago

I suspect you found this issue because you are scraping the entire API to fetch all books and chapters, yes?

Might I suggest using the source data here instead: open-bibles