search

seven1m / bible_api

Ruby web app that serves JSON API for open and public domain bibles
https://bible-api.com
MIT License
569 stars 104 forks source link

Update bibles submodule #81

Closed benjayahari closed 1 year ago

benjayahari commented 1 year ago

Description of the changes

Just an update of the bibles sub-module

There are several translations that were added not available through the API. I don't know if this is intentional though, if so I can close this MR

seven1m commented 1 year ago

I'm sorry, but there's more to it than that. We also have to update the https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages.rb file to handle any new languages. It's a bit tedious, and I haven't found any volunteers.

If we update the submodules and import new bible translations in other languages, but we don't also update that file to know how to handle the language, things will break. 😢

benjayahari commented 1 year ago

Oh I see. Thanks for the response. I may take a look at this if I have time