search

severb / graypy

Python logging handler for Graylog that sends messages in GELF (Graylog Extended Log Format).
https://www.graylog.org/
BSD 3-Clause "New" or "Revised" License
258 stars 90 forks source link

Gelf tcp tls #87

Closed jhildreth closed 6 years ago

jhildreth commented 6 years ago

I made some adjustments to GELFTcpHandler to facilitate using ssl to wrap sockets. This allows Graypy to be used to connect to TLS enabled TCP inputs on a Graylog server.

Addresses Issue #86

jhildreth commented 6 years ago

I'm not exactly clear on what is broken about the build on the 3.3 check...?

jhildreth commented 6 years ago

I've made the requested change, removing Python 3.3 from the list of tested versions.

tusharmakkar08 commented 6 years ago

I have reviewed the PR and it looks fine. @severb It would be great if you can review this too.

jhildreth commented 6 years ago

Hi! I just wanted to check in and see what the thoughts were on this PR? I have a project in progress now that requires the functionality in this change - I'd love to use official graypy instead of my fork, if possible.

Thank you!

severb commented 6 years ago

I'm not an expert on TLS, but the diff looks good to me.

severb commented 6 years ago

I just released version 0.3.1 which contains the change. Thanks for adding TLS!

jhildreth commented 6 years ago

Awesome, thanks so much!